search

primeTanM / portfolio

My portfolio
https://primetanm.vercel.app/
1 stars 9 forks source link

Add a Swipe from left to right framer motion in page transistion #1

Closed primeTanM closed 1 year ago

primeTanM commented 1 year ago

I have a basic fade in fade out framer motion added.If someone can change it to "swipe from right to left" kind of animation, it would be helpful.

Dhanunjay18 commented 1 year ago

Hey can u plz assign this issue to me

Aryan-Bhatt-pro commented 1 year ago

Hi, can you please assign the issue to me?

primeTanM commented 1 year ago

@Aryan-Bhatt-pro, sure you can take up this issue

Hey can u plz assign this issue to me @Dhanunjay18 I am opening another issue.You can take up that

primeTanM commented 1 year ago

@Aryan-Bhatt-pro are you working on it?

Aryan-Bhatt-pro commented 1 year ago

yes, sorry was busy lately, will try to complete it asap

Aryan-Bhatt-pro commented 1 year ago

Have created the PR regrading this issue. Please let me know if this suffices.

primeTanM commented 1 year ago

@Aryan-Bhatt-pro Hey, the effect is right, can you increase the transistion speed so it looks smoother

primeTanM commented 1 year ago

@Aryan-Bhatt-pro Also, there seems to be a scroll bar when we transistion to another page, usually blogs and contact page.So if possible fix that also image

Aryan-Bhatt-pro commented 1 year ago

ok will fix it

Aryan-Bhatt-pro commented 1 year ago

Hey @primeTanM, I have changed the transition speed between the pages. Regarding the scroll bar, I don't think it's due to the animation of pages or my code changes. It was there before also. Maybe you can open a new issue regarding this. Regarding the page transition let me know if it suffices.

primeTanM commented 1 year ago

@Aryan-Bhatt-pro Yeah, it's fine.Thanks