search

primefaces-extensions / primefaces-arquillian

PrimeFaces testing support for Arquillian
Apache License 2.0
16 stars 4 forks source link

Add checkstyle and PMD setup to build #10

Closed krichter722 closed 6 years ago

krichter722 commented 6 years ago

Most of the code already fulfills the suggested requirements. This should avoid the need for all these tiny "remove spaces" and "cosmetic" commits as well.

tandraschko commented 6 years ago

Big -1 for pmd Also i dont like the Changes to remove Abstract etc

tandraschko commented 6 years ago

Also "Else" in new line is used by PF and WE should so it the Same way

tandraschko commented 6 years ago

added checkstyle and skipped PMD for now

i never liked to strict PMD and to strict checkstyle as it leads to @SupressWarnings Review > PMD we can discuss it later.

krichter722 commented 6 years ago

Agreed. I extracted the non-controversial changes regarding PMD into #12. We can discuss them there separately.