primefaces-extensions / primefaces-extensions.github.com

Organization repo, only for homepage, wiki and issue tracker
https://primefaces-extensions.github.io/
70 stars 22 forks source link

AjaxErrorHandler in Extensions 3.1.0 doesn't work with PF 5.2 #327

Closed ova2 closed 9 years ago

ova2 commented 9 years ago

Thomas, can you look into this? It is reproducable in every example. The dialog doesn't appear. Furthermore, I think buttonOnclick="ajaxErrorHandler.hide();" in examples should be rewritten as buttonOnclick="PF('ajaxErrorHandler').hide();".

By the way, should we maybe remove this component in favor of the PrimeFaces' ExceptionHandler?

I would remove some old components from Extensions in the next major release.

tandraschko commented 9 years ago

If pavol doesn't like to maintain it anymore, we should just remove it. I really don't have much time and i will not invest it in components i've never used.

ova2 commented 9 years ago

Ok, I will remove it then if Pavol will not fix this issue in the next weeks.

ova2 commented 9 years ago

Done. The AjaxErrorHandler removed.

Added PrimeExceptionHandlerFactory and PrimeExceptionHandlerELResolver to the showcase in order to use the PrimeFaces' ExceptionHandler.

Species8372 commented 9 years ago

I am currently migrating from an older primefaces-extensions Version. I didnt find the removal of this feature anywhere, are there release-notes? Also i am quite concerned that tandraschko is using all other features of this library, else he would remove them when they are having a bug?!

ova2 commented 9 years ago

See the homepage http://primefaces-extensions.github.io/ and the release notes https://github.com/primefaces-extensions/primefaces-extensions.github.com/wiki/Release-Notes.

tandraschko commented 9 years ago

@Species8372 It's not my fault if there is no active community to fix bugs. Pavol isn't active since many many months and there is a ExpceptionHandler available in PF core. There is no reason for me or oleg to spend time to fix.