primefaces-extensions / primefaces-extensions.github.com

Organization repo, only for homepage, wiki and issue tracker
https://primefaces-extensions.github.io/
68 stars 22 forks source link

PF 5.2.10 Issue with PE InputNumber #354

Closed melloware closed 9 years ago

melloware commented 9 years ago

I am using p:outputlabel with a pe:inputnumber and it works fine in PF 5.2.9 but in 5.2.10 I am seeing this error upon rendering.

PF 5.2.10 PFE 3.2.0 Mojarra 2.2

java.lang.AbstractMethodError: org.primefaces.extensions.component.inputnumber.InputNumber.setLabelledBy(Ljava/lang/String;)V at org.primefaces.component.outputlabel.OutputLabelRenderer.encodeEnd(OutputLabelRenderer.java:64) at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:919) at org.primefaces.renderkit.CoreRenderer.renderChild(CoreRenderer.java:88) at org.primefaces.renderkit.CoreRenderer.renderChildren(CoreRenderer.java:71) at org.primefaces.component.panelgrid.PanelGridRenderer.encodeRow(PanelGridRenderer.java:196) at org.primefaces.component.panelgrid.PanelGridRenderer.encodeStaticBody(PanelGridRenderer.java:151)

tandraschko commented 9 years ago

Exntensions is not compatible with a elite release. We will fix it when we do a release for 5.3.

kito99 commented 9 years ago

Hello @tandraschko, to clarify, what you're saying is that you don't guarantee compatibility with Elite releases in between the major releases, correct? You're not saying that Extensions should never be used with Elite releases, are you?

tandraschko commented 9 years ago

Hey kito, exactly - it's to much effort to check compatibility and do releases after each elite release. You know, it's community based. Also, it's unlikely that components will not work with newer elite releases. AFAIR it didn't occur very often in the past.

ova2 commented 9 years ago

Agree with Thomas.

kito99 commented 9 years ago

Thanks, @tandraschko. Do you guys fix issues like this for PrimeFaces PRO users who have the PrimeFaces Extensions support option?

ova2 commented 9 years ago

I think if you have the PrimeFaces Extensions support option, it could be interesting for Thomas. Regarding me - I'm moving right now from JSF to AngularJS :-). My JSF activities are going down. I can still do small maintenance tasks and releases, but pull requests would be much better for us.

tandraschko commented 9 years ago

@kito99 never talked with anyone about such elite bugfix releases because it may really only work for a special elite version like 5.2.10. But i think doing this via the PrimeFaces Extensions support option might be no problem actually. Just need to think about if we really need a offical realease or it's enough to provide it via PrimeFaces portal.

xKopax commented 9 years ago

"Regarding me - I'm moving right now from JSF to AngularJS :-)." @ova2 I know it's offtopic, but too sad to read this ='(

fkjaekel commented 9 years ago

IMHO, since PrimeFaces Extensions is recognized by PrimeFaces (link inside PF showcase, Extensions forum inside official forum, etc), also because it's highly used, they should ensure that new Elite versions will keep compatible with Extensions.

tandraschko commented 9 years ago

We just don't have time to do that. The current community isn't very active and i can't maintain this project for every elite release cause i'm active in many projects. PrimeFaces PRO might be an option if you would like to sponsor it. Otherwise feel free to fix it and provide a pull request. You can build from the git master than.

fkjaekel commented 9 years ago

Maybe a Elite program for Extensions too? I would surely pay for it.

We need some guarantee that Elite + Extensions will play nice together.

tandraschko commented 9 years ago

I will talk with Oleg and Cagatay and will come back to you via this ticket.

melloware commented 9 years ago

Thanks for looking into this @tandraschko . We have been a huge PF supporter and PRO customer for 3 years and we extensively use PE Timepicker and Inputnumber in our suite of applications. This marrying of Extensions + PRO would be extremely valuable.

alfonx commented 9 years ago

A quick&diry fix that can help:

  1. Copy InputNumber.java from the extensions source code into your project
  2. Add the new required methods:

    @Override public void setLabelledBy(String labelledBy) { getStateHelper().put("labelledby", labelledBy); }

    @Override public String getLabelledBy() { return (String) getStateHelper().get("labelledby"); }

    @Override public String getValidatableInputClientId() { return this.getClientId(getFacesContext()) + "_input"; }

  3. Now there is a good chance that your server (e.g. tomcat7) will pickup the modified class and everything works live a charm.

Note: I know this is an ugly hack, but this approach worked for me many times... Remember to delete or udpate your local copy of InputNumber.java when version 4.0.0 is released.

tandraschko commented 9 years ago

Fixed in trunk. Please test test test everything!

melloware commented 9 years ago

5.3 has been officially released. When is PFE getting released to match it?

ova2 commented 9 years ago

http://forum.primefaces.org/viewtopic.php?f=14&t=43543&sid=a058273d2070b6c5ef6b2fb2096ee781