search

primefaces-extensions / primefaces-extensions.github.com

Organization repo, only for homepage, wiki and issue tracker
https://primefaces-extensions.github.io/
69 stars 22 forks source link

New Component: GitHub #440

Closed melloware closed 7 years ago

melloware commented 7 years ago

GitHub is component to display your Github Repositories.

Based on jquery.github.js by Zeno Rocha.

Example:

<pe:github repository="primefaces/primefaces" iconForks="true" iconIssues="true" iconStars="true" />

Renders this cool box displaying the info and links about your project.

image

I did find one issue with this plugin which I have reported: https://github.com/zenorocha/jquery-github/issues/48

melloware commented 7 years ago

Example here: http://melloware.dyndns-free.com:8080/pe-showcase/sections/github/basicUsage.jsf

tandraschko commented 7 years ago

@melloware go ahead!

Just don't like the "download as zip" buttom from style perspective ;)

I have no problem if you add new component and the css/js are not merged in the PE core files. Just the quality of the widgets should be high enough and it should be no "duplicate" component.

melloware commented 7 years ago

Agreed I typically have not been adding the CSS/JS to the PE core for any compoent. My thoughts being that most components in PFE are so specialized that if someone wants to use one of these extensions components only then should its CSS/JS load and other users not be punished with loading JS they will never use.

melloware commented 7 years ago

Ahh the Download button looks fine locally it is munged on deploy which means something must be messing with the SVG font in the "compress" or "copy" resource step of the Maven build. I will fix.

melloware commented 7 years ago

OK so it turned out to be the PFE Resources Optimizer using YUI Compressor and it has this bug converting 0px; to 0 which not all browsers respect.

https://github.com/yui/yuicompressor/issues/113

melloware commented 7 years ago

Actually even worse its this issue: https://github.com/yui/yuicompressor/issues/124

melloware commented 7 years ago

OK was able to work around both issues by changing to...

text-indent: 1px;
font-size: 2em;

Now it compresses properly and the dowload button looks correct.