search

primefaces-extensions / primefaces-extensions.github.com

Organization repo, only for homepage, wiki and issue tracker
https://primefaces-extensions.github.io/
70 stars 22 forks source link

LetterAvatar: Invert CSS font-color depending on background-color #775

Closed aripddev closed 4 years ago

aripddev commented 4 years ago

Solution to https://github.com/primefaces-extensions/core/pull/101#issuecomment-608584862

There is mix-blend-mode: difference

melloware commented 4 years ago

Were you going to submit a new PR for this fix?

aripddev commented 4 years ago

yesterday I tried twice but cannot submit because of too many conflicts. So I closed PRs. I will try it again after completed fuzzysearch

melloware commented 4 years ago

Yes you need to make a new branch in your fork. But first you must resync the changes to your fork. I will send you instructions.

melloware commented 4 years ago

To resync your master with all the changes.

git fetch upstream git checkout master git merge upstream/master git push origin master

Now your master has the latest code. Create a new branch now called PFE775 and you can fix just this bug and submit a PR from that branch.

aripddev commented 4 years ago

Thanks @melloware . I submitted PRs for both core and showcase.

melloware commented 4 years ago

@jepsar @aripddev here is the current showcase screenshot

image