search

primefaces-extensions / primefaces-extensions.github.com

Organization repo, only for homepage, wiki and issue tracker
https://primefaces-extensions.github.io/
68 stars 22 forks source link

Remove Commons Lang usage #804

Closed tandraschko closed 4 years ago

tandraschko commented 4 years ago

Most of the time utils like StringUtils are used, which are already available in PF core. Use them instead common-langs

Maybe we can reven remove the dependency.

tandraschko commented 4 years ago

Replaced commons-lang by ~60 LOC

@melloware the only usage left is StringEscapeUtils. Can we remove this taglib functions (never used it but introduced it ;)) ? or can we reuse the owas escape stuff from PF core?

melloware commented 4 years ago

Yep I think we can replace with OWASP EscapeUtils.

As for JSON can't we do something similar as PF and use the JSONObject instead of GSON?

tandraschko commented 4 years ago

would you take care of the Owasp EscapeUtils thing? i will check JSON now

melloware commented 4 years ago

yep! on it.

melloware commented 4 years ago

OK I removed all Commons Lang and switched it to test scope in the pom.xml because some unit tests were using it. so now it will no longer automatically be downloaded by PFE. Thanks for working on this!

tandraschko commented 4 years ago

what about that taglib functions?

melloware commented 4 years ago

let me look at those. I didn't even realize they were there. Maybe we should remove them?

tandraschko commented 4 years ago

yeah, thats what i said 2 posts earlier here :D i would remove them and add a migration guide hint to add them in the application manually (commons lang + the taglib entry)

melloware commented 4 years ago

Sorry i missed that I will remove them.