primefaces / primefaces

Ultimate Component Suite for JavaServer Faces
http://www.primefaces.org
MIT License
1.77k stars 752 forks source link

JavaEE JAR contains JakartaEE URN taglib #12138

Open tandraschko opened 2 months ago

tandraschko commented 2 months ago

i think it should only be in the jakarta shade

melloware commented 2 months ago

yes it should only be in the shaded JAR let me look at when that code executes.

melloware commented 2 months ago

@tandraschko have to re-open this as what has to happen is the JAR builds then the Jakarta JAR builds then I remove the URN from the main JAR. When doing a deploy to Maven Central it gets rejected saying the PrimeFaces JAR doesn't match its checksum ASC so it knows its been modified in the build process and won't allow it to be released.

melloware commented 1 month ago

cc @FranzHagel from discussion: https://github.com/orgs/primefaces/discussions/2307