ConfirmPopup / ConfirmDialog: Default icon not displayed if not provied by p:confirm

fanste commented 2 months ago

p:confirmDialog and p:confirmPopup do provide an attribut named icon. But the default icon is not shown, if no icon is provided by p:confirm.

p:confirmDialog: Icon is set to null, if p:confirm provides no icon (misses correct check for no icon). And if p:confirm provides an icon, the default one is removed permanently, see here.
p:confirmPopup: Default Icon is always permanently removed and the one from p:confirm is set, if provded, see here.

The same somehow applies to header and message attributes. Once overwritten by p:confirm specific value, the default is lost.

Maybe the handling of p:confirm specific value vs default values needs discussion, but default icon is clearly not working as designed, IMHO.

No response

Default icon should be visible, if no icon is provied by p:confirm

Community

10, 15.0.0-SNAPSHOT

No response

Mojarra

2.2

8

No response

melloware commented 2 months ago

@fanste i am little confused as to the issue do you have a PR to propose?

tandraschko commented 1 month ago

i will mark this as enhancement, i think its currently implemented by design without that usecase in mind it would be great if you can provide a PR

primefaces / primefaces