primefaces / primefaces

Ultimate Component Suite for JavaServer Faces
http://www.primefaces.org
MIT License
1.78k stars 754 forks source link

DatePicker: Accessibility 508 Compliance #4685

Closed kaushikmeduri closed 1 year ago

kaushikmeduri commented 5 years ago

1) Environment

2) Expected behavior

We are using https://www.primefaces.org/showcase/ui/input/datePicker.xhtml. We are expecting it to be 508 / key board / screen reader compliant like https://dequeuniversity.com/library/aria/date-pickers/sf-date-picker ...

3) Actual behavior

Date Picker is not accessibly via key board for date selections ..

4) Steps to reproduce

use any of https://www.primefaces.org/showcase/ui/input/datePicker.xhtml. Date Picker is not accessibly via key board for date selections We are expecting it to be 508 / key board / screen reader compliant like https://dequeuniversity.com/library/aria/date-pickers/sf-date-picker

5) Sample XHTML

<h:outputText id="reportingPeriodStart" value="#{homeBean.startDate}" >

</h:outputText>

6) Sample bean

@ManagedBean(name = "homeBean") @ViewScoped public class HomeController {

private Date startDate;

public Date getStartDate() { return startDate; }

public void setStartDate(Date startDate) { this.startDate = startDate; } } ..

tandraschko commented 5 years ago

Feel free to provide a PR

kaushikmeduri commented 5 years ago

We have Elite Account . Please advise what is PR and steps to create PR .

tandraschko commented 5 years ago

google about GitHub Pull Requests (PR)

kaushikmeduri commented 5 years ago

hi , We have not implemented any date pickers yet. Do you know any prime faces extension some one already have for this ..

kaushikmeduri commented 5 years ago

We do not have fix . Please advise if prime faces can provide a price quote for fixes to be included as patch. In the past our agency has some work done for 508 fixes

tandraschko commented 5 years ago

Please see: primefaces.org/support - there is a "get a quote" button

christophs78 commented 4 years ago

As a reference what others do: https://material.angular.io/components/datepicker/overview#keyboard-interaction

christophs78 commented 4 years ago

We may try to backport primefaces/primeng#4695, primefaces/primeng@ea9596b from PrimeNG for DatePicker. (DatePicker is the replacement for Calendar) It´s a bit sad PrimeTek only added this for PrimeNG, PrimeReact and PrimeVue. Not much love for PrimeFaces.

melloware commented 4 years ago

Agreed. And keyboard accessibility would be a huge feature. I feel like we need to start monitoring the PrimeNG issues for features that get added so we can try and keep PF in sync.

abhishar03 commented 4 years ago

Is this Still open , same issues

melloware commented 4 years ago

@abhishar03 Yes this ticket is still open and has not been implemented yet.

efibn commented 3 years ago

This issue really have to get prioritized, PLEASE !

melloware commented 3 years ago

@efibn your best bet might be to pay for a 1 time PRO support to PrimeTek and fund this issue.

efibn commented 2 years ago

@yigitfindikli Please take a look at this, if you open calendar from dialog it cannot be controlled by the keyboard, for accessibility purposes, same goes for Calendar that is in between dates. Please take a look at this

melloware commented 2 years ago

@efibn @yigitfindikli is the PrimeNG lead and this is the PrimeFaces ticket. Do you have the right issue tracker?

Bukama commented 1 year ago

The problem that the DatePicker is not accessible via keyboard, was also a downrating in the accessibilty tests of our web-apps. As it is planed that Primefaces 13 should focus on accessibility (according to Cagatay Civici) I would like to ask the whole team at PrimeTek to give this issue the needed ressourced to get fixed.

jepsar commented 1 year ago

The problem that the DatePicker is not accessible via keyboard, was also a downrating in the accessibilty tests of our web-apps. As it is planed that Primefaces 13 should focus on accessibility (according to Cagatay Civici) I would like to ask the whole team at PrimeTek to give this issue the needed ressourced to get fixed.

Agreed, but keep in mind that this is the community edition issue tracker. https://github.com/primefaces/primefaces#community--elite--pro

Bukama commented 1 year ago

Agreed, but keep in mind that this is the community edition issue tracker.

I'm totally aware of this. Nevertheless I hope that (and warmly ask) the PrimeTek team has the same opinion that the DatePicker is a largely used component which should be accessible and decides therefore to put "more than regular" ressource in the upcoming version, when accessibility is promoted widely for all PrimeTek libaries. Maybe (if technically possible) reusing code or even ressources from PrimeNG lib, which copyrights are also at PrimeTek might reduce the overall costs for reaching the goal.

So please don't see my comment as a "I WANT YOU TO DO THIS! NOW!"-claim ❤

melloware commented 1 year ago

as far as I know the PrimeVue Calendar is now 100% accessible: https://www.primefaces.org/primevue/calendar

Those fixes will eventually be ported to our PF DatePicker.

ZeroBrushV2 commented 1 year ago

as far as I know the PrimeVue Calendar is now 100% accessible: https://www.primefaces.org/primevue/calendar

Those fixes will eventually be ported to our PF DatePicker.

I would like to mention also the PrimeReact Calendar is also 100% accessible: https://www.primefaces.org/primereact/calendar/

Hope the fix comes soon!

melloware commented 1 year ago

I started working on this and have been making it match all the accessibility changes from PrimeVue. Making good progress so far.

tarwork commented 1 year ago

@melloware thank you for working on this. We are facing this exact issue literally right now in getting an app past our internal accessibility audit.

We have the ELITE license so hopefully we can get a point release with the fix ?

melloware commented 1 year ago

@tarwork after the team thoroughly tests my changes (next couple of weeks) I can ask PrimeTek about porting to to an Elite release.

Bukama commented 1 year ago

@tarwork after the team thoroughly tests my changes (next couple of weeks) I can ask PrimeTek about porting to to an Elite release.

It was announced that ELITE and Community are combined to a free LTS since 13.0.0, so should be available for all, right?

edit: sorry for bringing this up here as its offtopic

melloware commented 1 year ago

@Bukama you are totally right but I just worry because so far I have been patching 13.0.1 with bugfixes only this is a new feature/breaking change. But we will get more clarity from PrimeTek and the other team members before we do anything.

fkalanti commented 2 months ago

Hi, this is a really often needed feature, so if i understand correctly only available from Primefaces Version 14 on? Does the possibility exist to make the DatePicker accessible also in Version 13 of Primefaces? Thank you!

melloware commented 2 months ago

Unfortunaltey @fkalanti this was such a massive change to the component there is no way it was just a "backpatch" to 13. So 14.0.2 is your best best if you want this feature.