primefaces / primelocale

MIT License
74 stars 108 forks source link

Add missing text id.json #150

Closed ganjarsetia closed 7 months ago

ganjarsetia commented 7 months ago

As titled

melloware commented 7 months ago

If you havee the time I would love ID translation of the following for PrimeFaces.

      "datatable.sort.ASC": "activate to sort column ascending",
      "datatable.sort.DESC": "activate to sort column descending",
      "datatable.sort.NONE": "activate to remove sorting on column",
      "colorpicker.OPEN": "Open color picker",
      "colorpicker.CLOSE": "Close color picker",
      "colorpicker.CLEAR": "Clear the selected color",
      "colorpicker.MARKER": "Saturation: {s}. Brightness: {v}.",
      "colorpicker.HUESLIDER": "Hue slider",
      "colorpicker.ALPHASLIDER": "Opacity slider",
      "colorpicker.INPUT": "Color value field",
      "colorpicker.FORMAT": "Color format",
      "colorpicker.SWATCH": "Color swatch",
      "colorpicker.INSTRUCTION": "Saturation and brightness selector. Use up, down, left and right arrow keys to select.",
      "spinner.INCREASE": "Increase Value",
      "spinner.DECREASE": "Decrease Value",
      "switch.ON": "On",
      "switch.OFF": "Off",
      "messages.ERROR": "Error",
      "messages.FATAL": "Fatal",
      "messages.INFO": "Information",
      "messages.WARN": "Warning",
ganjarsetia commented 7 months ago
datatable

@melloware Sure! But I don't see that in https://github.com/primefaces/primelocale/blob/main/en.json where I can add those translations?

melloware commented 7 months ago

@ganjarsetia its for PrimeFaces JSF which has more translations than vue/react/ng.

See: https://github.com/primefaces/primefaces/blob/master/primefaces/src/main/resources/META-INF/resources/primefaces/locales/locale-en.js

And the Indonesian you will see here: https://github.com/primefaces/primefaces/blob/master/primefaces/src/main/resources/META-INF/resources/primefaces/locales/locale-in.js

ganjarsetia commented 7 months ago

@ganjarsetia its for PrimeFaces JSF which has more translations than vue/react/ng.

See: https://github.com/primefaces/primefaces/blob/master/primefaces/src/main/resources/META-INF/resources/primefaces/locales/locale-en.js

And the Indonesian you will see here: https://github.com/primefaces/primefaces/blob/master/primefaces/src/main/resources/META-INF/resources/primefaces/locales/locale-in.js

@melloware Ah I see, Ok I will create PR in that repo. Even though I don't code in Java :grin:

Btw, I saw your code, Indonesia country code is ID not IN. IN is for India. See this picture

image

melloware commented 7 months ago

Yeah its weird in Java it seems to be in_ID as the Indonesian locale based on this stack overflow: https://stackoverflow.com/questions/55955641/correct-locale-for-indonesia-id-id-vs-in-id

You can change the language right in the PF showcase:https://www.primefaces.org/showcase/index.xhtml?jfwid=a4774

image