Publish PrimeLocale to npm?

[1EDExg0ffyXfTEqdIUAYNZGnCeajIxMWd2vaQeP]

Would be simpler to use and update to newer versions.

[melloware]

Also has been mentioned on Discord and PrimeTek has put it on their list!

[C0ZEN]

I am so surprised that this is not the case already 🤔

[Anders142536]

I tried to add this repository to our dependencies via github dependency syntax and the install fails, probably because there is no package.json file. Maybe just add that? I don't think it has to be hosted on npm necessarily.

[melloware]

Do you have instructions on how your included using GitHub syntax and then I can test and add a package.json. Thanks! I didn't know that was possible!

[Anders142536]

Oh of course, I should have included a link to the documentation in the first message already: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#github-urls

[melloware]

OK I added package.json but didn't test it yet if you want to test it: https://github.com/primefaces/primelocale/blob/main/package.json

[Anders142536]

npm definitely treats this now as an npm package, but complains about trailing commas. i created a pull request that removes them

[melloware]

You should now be able to do this in your package.json

"dependencies": {
        "primelocale": "primefaces/primelocale",

[Anders142536]

The only issue we see in this solution now is that our company internal caches for depenency packages will not automatically work with github dependencies. I guess other people will have the same issue, so maybe uploading it to npm repo still makes sense.

[melloware]

Agreed but according to the docs you can add a commit ID hash in your url and it will pull that version. Still not as good as in NPM but better than nothing

[melloware]

React example how to use PrimeLocale: https://stackblitz.com/edit/react-3glwrd?file=src%2FApp.tsx,package.json,src%2Findex.tsx

[jerlam06]

Agreed but according to the docs you can add a commit ID hash in your url and it will pull that version. Still not as good as in NPM but better than nothing

@melloware What docs are you referring to please?

[melloware]

Sorry it's in the NPM docs for using just a git project like above. I had no idea you could do that.

PrimeTek is aware and is working on getting this released for real on NPMJS.

https://www.pluralsight.com/guides/install-npm-packages-from-gitgithub

[PotatoesMaster]

I guess this package is unofficial then.

[melloware]

It is and I asked him to take it down. It's way out of date and should be released by PrimeTek.

[iwnow]

npm i github:primefaces/primelocale

[alexef]

PrimeTek is aware and is working on getting this released for real on NPMJS.

is there another issue I can track?

[melloware]

@cagataycivici @tugcekucukoglu @cetincakiroglu any update on this?

[melloware]

1.0.0 is now published in NPM!

[dbelob]

1.0.0 is now published in NPM!

Thanks!

@melloware What is the future release strategy for new versions?

• new version after each new string resource
• new version every month (quarter, year) if there are changes
• another variant

[melloware]

For me I can just cut a release whenever anyone needs one but doing it on every change feels right to me.

[dbelob]

doing it on every change feels right to me.

I agree with this opinion.

May be

• patch (1.0.0 -> 1.0.1) – any changes without new string resources
• minor (1.0.0 -> 1.1.0) – new string resource (-s) with/without other changes
• major (1.0.0 -> 2.0.0) – lots of new string resources

[melloware]

totally agree with that semver approach!