search

primefaces / primeng-sass-theme

PrimeNG Theming with SASS
MIT License
103 stars 68 forks source link

Message -> from version 17.16 no more "error" but "danger" #134

Open meriturva opened 1 month ago

meriturva commented 1 month ago

The latest version of Primeng just replace "error" message type with "danger" one:

https://github.com/primefaces/primeng/blob/master/src/app/components/message/message.ts#L39

So basically sass doesn't work anymore:

https://github.com/primefaces/primeng-sass-theme/blob/b47e8850aae391ed8f55722c226f0bffd9f7ff75/theme-base/components/messages/_inlinemessage.scss#L39

I still don't catch why primeng demo site doesn't use this package!

meriturva commented 1 month ago

@cetincakiroglu If necessary I could make a PR easily....tell me.

gbalatckii commented 3 weeks ago

Still relevant in version 17.18.0

cetincakiroglu commented 3 days ago

Hi,

Thanks for reporting the issue.

Correct severity options for the message and toast components should be as follows:

severity: 'success' | 'info' | 'warn' | 'error' | 'secondary' | 'contrast' | undefined;

Possibly, this issue stems from a problem occurring when merging branches in PrimeNG repo.

Styles are correct, classes should be -error & -warn. This issue will be fixed in PrimeNG 17.18.3 release this week.