search

primefaces / primeng

The Most Complete Angular UI Component Library
https://primeng.org
Other
10.28k stars 4.56k forks source link

Calendar: The year options have blank labels when no date has been selected, yet #12552

Open pgkavogiannis opened 1 year ago

pgkavogiannis commented 1 year ago

Describe the bug

While opening a <p-calendar/> date picker (selection mode = range), the year options seem to exist, but there are not labels for them

image

Environment

Operating system: Windows 10 Pro IDE: Webstorm Package manager: yarn, node

Reproducer

No response

Angular version

15.0.3

PrimeNG version

15.0.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.19.0

Browser(s)

Firefox v109.0

Steps to reproduce the behavior

No response

Expected behavior

No response

pgkavogiannis commented 1 year ago

There is not an error control handling for non-valid values (i.e. empty array) in the isYearSelected() method in the following line: https://github.com/primefaces/primeng/blob/master/src/app/components/calendar/calendar.ts#L1364 where accessing this.value[0]

sajimavelil commented 1 year ago

Support expecting for this problem

sebastianamaro commented 1 year ago

Same issue here

image

Chrome Version 114.0.5735.199

PrimeNG version: "primeng": "^15.2.0",