search

primefaces / primeng

The Most Complete Angular UI Component Library
https://primeng.org
Other
10.08k stars 4.54k forks source link

TabMenu - QueryParams ignored in isActive function #12631

Open valentindruon opened 1 year ago

valentindruon commented 1 year ago

Describe the bug

Currently, if a TabMenu's items all have the same routerLink value, and are only different based on queryParams, the isActive function returns true for every one of these items.

This leads to every items having the p-highlight class and being showed as active to the user

Environment

Angular 13.3.1 PrimeNG 13.4.1

Reproducer

No response

Angular version

13.3.11

PrimeNG version

13.4.1

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

14.9.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

semahawk commented 11 months ago

Just ran into this issue on the latest version, 16.4.1. @valentindruon any chance on reopening #12630?

valentindruon commented 11 months ago

Idk, my pull request has been ignored