search

primefaces / primeng

The Most Complete Angular UI Component Library
https://primeng.org
Other
10.07k stars 4.54k forks source link

Component selector naming convention #13393

Open ziuniecki opened 1 year ago

ziuniecki commented 1 year ago

Hi, chevron left component has invalid selector.

https://github.com/primefaces/primeng/blob/ebe3f946250ebf801a4787b25b006315ab553063/src/app/components/icons/chevronleft/chevronleft.ts#L5C16-L5C31

You should follow standards for custom elements to avoid web accessibility problems:

https://angular.io/guide/styleguide#component-selectors

https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom-element-name

SoyDiego commented 1 year ago

You are right, @ziuniecki but I don't know if PrimeNG Team will do this because If they do, will generate breaking changes for all the users and is not the idea.

ziuniecki commented 1 year ago

yeah it will be breaking change but its just selector name change... Or just make it deprecated and remove those components in other versions, when teams will have time to migrate. PrimeNG made more complicated breaking changes in the past.

SoyDiego commented 1 year ago

yeah it will be breaking change but its just selector name change... Or just make it deprecated and remove those components in other versions, when teams will have time to migrate. PrimeNG made more complicated breaking changes in the past.

I agree with your issue but I'm not part of PrimeNG Team or the person who take decision, only a contributor and I don't know if they will do. But I agree because is important follow the standards