search

primefaces / primeng

The Most Complete Angular UI Component Library
https://primeng.org
Other
10.56k stars 4.61k forks source link

Primeng css #14116

Open a-zana opened 1 year ago

a-zana commented 1 year ago

Describe the bug

in the 'primeng/resources/primeng' there is:

  input[type='button'],
  input[type='submit'],
  input[type='reset'],
  input[type='file']::-webkit-file-upload-button,
  button {
      border-radius: 0;
  }

this css is too generic and have a deep impact with for example bootstrap (importing bootstrap with a layer and set the boostrap layer before primeng as have to be).

Environment

use bootstrap with primeng and try to use for exmple the bootstrap button-group

Reproducer

No response

Angular version

16.2.19

PrimeNG version

16.6.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.10.0

Browser(s)

Chrome 119

Steps to reproduce the behavior

No response

Expected behavior

It is better to do somenthing like:

[class^='p-'] {
    input[type='button'],
    input[type='submit'],
    input[type='reset'],
    input[type='file']::-webkit-file-upload-button,
    button {
        border-radius: 0;
    }
}

so to apply this rule only to the primeng components

egorbwork commented 5 months ago

I agree, I encountered a similar problem with the buttons.