primefaces / primeng

The Most Complete Angular UI Component Library
https://primeng.org
Other
9.53k stars 4.47k forks source link

Fixes #15022: dialog not closing #15345

Closed dobanisola-scottlogic closed 2 weeks ago

dobanisola-scottlogic commented 2 weeks ago

Fixes #15022 The bug happens because there's a onMouseDown event on the dialog header that does nothing if the element has class 'p-dialog-header-icon' else it does the drag logic. However when a user clicks on the TimeIcon instead of the button (that has the p-dialog-header-icon css class) , the implements the drag logic instead of closing. I have added the css class of the TimesIcon to fix the bug.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **primeng** | ⬜️ Ignored ([Inspect](https://vercel.com/primetek/primeng/DUBbbCeWwNwYMcb52mErrij1iZHf)) | [Visit Preview](https://primeng-git-fork-dobanisola-scottlogic-fixdialo-03b5f9-primetek.vercel.app) | | Apr 24, 2024 8:23am |