search

primefaces / primeng

The Most Complete Angular UI Component Library
https://primeng.org
Other
9.53k stars 4.47k forks source link

Fixes #15367 - SpeedDial non-linear menu items are misaligned #15368

Closed Dive576 closed 2 weeks ago

Dive576 commented 2 weeks ago

Fixes #15367

Background

In a previous PR (#13726), a change was made so that menu item actions would not be added to the DOM unless the speed dial menu was visible. This was done to prevent those menu items from interfering with clicks on elements below the items while the menu was closed. However, the size of the menu item actions is used to position the items and the calculation is performed while the actions aren't in the DOM resulting in the items being misaligned. Additionally, the removal of the menu item actions causes the closing animation of the Speed Dial to not be displayed.

Changes

  1. Removes the changes from #13726 and uses CSS to achieve the desired effect.
  2. Fixes a bug with accessing the value of the focusedOptionIndex signal which was causing an exception when pressing the enter key on a focused menu item.
vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **primeng** | ⬜️ Ignored ([Inspect](https://vercel.com/primetek/primeng/7RmRLqJJXW2N5JviEm9cgvqBNiBX)) | [Visit Preview](https://primeng-git-fork-dive576-issue-15367-primetek.vercel.app) | | Apr 26, 2024 0:33am |