Message: New severity not reflected in styles

EinfachHans commented 1 week ago

Describe the bug

In https://github.com/primefaces/primeng/pull/15471 new severity options were added. For the message component they were named differently before and the changes were not applied to the styles. The error and warn options are removed, but still used for styles in all the theme files. So the new danger and warning have no styling.

Environment

//

Reproducer

No response

Angular version

17.3.8

PrimeNG version

17.16.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.12.2

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

Shusty-6th commented 1 week ago

After updating primeNg to the new version, we have the same problem. I can see that for message severity error is no longer supported and instead takes danger, however the component displays badly because the theme css message still uses error and not danger.

Rotzbua commented 1 week ago

With typescript it leads to an compile error:

error TS2322: Type '"error"' is not assignable to type '"success" | "info" | "warning" | "danger" | "help" | "primary" | "secondary" | "contrast" | null | undefined'. <p-message severity="error"

vinishiru commented 1 week ago

Temporary solution for typescript that corrects the style, but displays an exclamation icon instead of times icon.

[severity]="$any('error')"

primefaces / primeng