Sidebar: Focus not trapped when modal = true - Githubissues

primefaces / primeng

The Most Complete Angular UI Component Library

https://primeng.org

Other

10.64k stars 4.63k forks source link

Sidebar: Focus not trapped when modal = true #16275

Open jentryalexander opened 3 months ago

jentryalexander commented 3 months ago

Describe the bug

Since a sidebar is intended to be treated as a modal when the modal input is set to true, focus should be trapped within that sidebar as it is with other components such as confirmDialog

Environment

angularJS/Angular hybrid application. The Angular portion is running primeng.

Reproducer

No response

Angular version

17.1.0

PrimeNG version

17.4.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.13.0

Browser(s)

No response

Steps to reproduce the behavior

Setup a primeng sidebar with controls inside.
Tab through the controls.
Observe that rather than cycling through the controls in the sidebar, focus leaves the sidebar and starts tabbing through browser controls.

Expected behavior

Focus should cycle through the controls inside of the sidebar.

github-actions[bot] commented 13 hours ago

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. :sparkles: Thank you for your contribution! :sparkles: