primefaces / primeng

The Most Complete Angular UI Component Library
https://primeng.org
Other
10.35k stars 4.58k forks source link

Component: Table responsiveLayout="stack" doesn't work since v17.8.9 #16510

Open zlatanov opened 1 week ago

zlatanov commented 1 week ago

Describe the bug

Setting reponsiveLayout to "stack" doesn't work in 17.18.9. It works with 17.18.8. I suspect that this PR https://github.com/primefaces/primeng/pull/16210 is the culprit.

https://github.com/primefaces/primeng/compare/17.18.8...17.18.9.

Check the demos - https://primeng.org/table#responsive-stack, it doesn't work also.

Environment

Windows 11

Reproducer

No response

Angular version

18.2.6

PrimeNG version

17.18.9

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.10.0

Browser(s)

Edge

Steps to reproduce the behavior

Open https://primeng.org/table#responsive-stack

Expected behavior

The table should be rendered correctly.

imaksp commented 1 week ago

Hi this could be issue with v17.18.9+ as you mentioned, but its deprecated in v18 & only scroll is supported, so if you use this option , you won't be able to upgrade.

zlatanov commented 1 week ago

Hi this could be issue with v17.18.9+ as you mentioned, but its deprecated in v18 & only scroll is supported, so if you use this option , you won't be able to upgrade.

Where can I read about its deprecation?

imaksp commented 4 days ago

Hi, you can check it here: https://v18.primeng.org/table#api.table.props.responsive

it says table is now always responsive with scroll behaviour.

zlatanov commented 3 days ago

Responsive is deprecated because it's always responsive, but responsiveLayout is not. And "stack" mode is still listed as supported.

imaksp commented 3 days ago

Ok, that property is present I missed it, but its still not available in v18 demo, may be demo needs to be updated. https://v18.primeng.org/table