primefaces / primeng

The Most Complete Angular UI Component Library
https://primeng.org
Other
10.35k stars 4.58k forks source link

ControlValueAccessor interface support for DataTable #1771

Closed windwolfreal closed 6 years ago

windwolfreal commented 7 years ago

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

In many case, I want to use data-table with Reactive Form style, so that i can maintain a complex entity-have some simple type fields and some collection fields--in one formGroup, and a form control need to implement ControlValueAccessor interface. So it would be nice if data-table support reactive form style, and I can maintain the table data by a FormArray

usmanniqbal commented 7 years ago

Any update on this ticket I am required same functionality?

cagataycivici commented 7 years ago

Keeping it here to see how many more users need it.

jaredmartinez commented 7 years ago

Would like to be able to use a Reactive form in a data table as well. thanks!

vatsalpande commented 7 years ago

I am trying to do the same. Any plan to include this? It will be really a great addition.

cagataycivici commented 7 years ago

Yes, we'll try do to it for 4.1.1.

mlakhara commented 7 years ago

Really happy to see the last update. I myself am working on creating a wrapper on top of PrimeNg Datatable. This would be a big boost for the library as well.

skormel commented 7 years ago

Any plan to include this feature? We're working with reactive forms that include datatable so this feature will be great addition.

michaeljohnbennett commented 7 years ago

yes I'm having the same issue. when I bind to a form control with a selection as the values it won't work right now.

Also the pristine/isDirty checks don't get triggered on the form even if I'm bound to the formControl.

I have to write some custom logic into the form save method before emitting this back to my data store (I'm currently using ngrx redux like store for entities) so thats another issue entirely.

The datatable is amazing, having these features would be Awesome to the power infinity! 😃

Coffee-Tea commented 6 years ago

Is it already available in PrimeNg? I have 4.1.3 version and can't type anything within formControls in datatable :(

stephanie-dm commented 6 years ago

This was already asked in this issue as well: https://github.com/primefaces/primeng/issues/1142

cagataycivici commented 6 years ago

p-dataTable is deprecated and will be removed in favor of the new p-table (aka TurboTable) of 5.1.0 so closing the issue. Please try the new p-table once 5.1.0 is released.

jaredmartinez commented 6 years ago

whats the eta on 5.1 @cagataycivici ? Thanks for all the hard work!

sbkpilot1 commented 6 years ago

can anyone confirm if CVA support is present in the new TurboTable? I checked the docs and there isn't any reference to Reactive Forms so I am guess no? Confirmation would be appreciated :)

skormel commented 6 years ago

Is there any update on this issue/feature?

aleq commented 4 years ago

Any update? Can you share example of using editable p-table (TurboTable) with reactive form (FormArray), I couldn't find any working solution so far.