primefaces / primeng

The Most Complete Angular UI Component Library
https://primeng.org
Other
10.37k stars 4.59k forks source link

Checkbox component has "checkbox" role on div element instead of input element #9758

Closed mbquinonez closed 1 year ago

mbquinonez commented 3 years ago

I'm submitting a ... (check one with "x")

[ x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior Checkbox component has misplaced role attribute which causes failure of wcag2 test https://dequeuniversity.com/rules/axe/4.1/label

Expected behavior Checkbox should should pass wcag2 tests

Minimal reproduction of the problem with instructions Use Checkbox component and run accessibility tools such as axe

What is the motivation / use case for changing the behavior? To pass automated accessibility audits

Please tell us about your environment:

Angular version: 11

PrimeNG version: 11

Browser: Chrome

mertsincan commented 1 year ago

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap? Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,