search

primefaces / primereact

The Most Complete React UI Component Library
https://primereact.org
MIT License
6.58k stars 989 forks source link

DataTable Reorder is not working in tablet or mobile devices #2444

Open CodeLake opened 2 years ago

CodeLake commented 2 years ago

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports) No need for sandbox as the behaviour is reproducible using the demo url https://www.primefaces.org/primereact/showcase/#/datatable/reorder

Current behavior

Visit https://www.primefaces.org/primereact/showcase/#/datatable/reorder on a desktop or laptop and you will be able to reorder rows using mouse. Visiting the same page on tablet or mobile devices, you can't reorder the rows.

Expected behavior

The row reorder should also work on tablet or mobile devices.

Minimal reproduction of the problem with instructions

No need for sandbox as the behaviour is reproducible using the demo url https://www.primefaces.org/primereact/showcase/#/datatable/reorder

  1. Visit above url on desktop and try to reorder rows. It will work.
  2. Visit above url on tablet and try to reorder rows, it will NOT work.
  3. Visit above url on mobile and try to reorder rows, it will NOT work.

Please tell us about your environment:

Samsung Galaxy S10 Plus, iPhone, iPad.

melloware commented 1 year ago

I am pretty sure this entails using mousedown, touchstart instead of drag operations similar to: https://github.com/primefaces/primereact/pull/3715

yaiir-a commented 1 year ago

Hi there! Just wondering about this one - it says it was added to milestone 8.7.4 but that milestone was replaced by 9.0.0. Was this missed or has it been deprioritised?

Thanks

melloware commented 1 year ago

No i thought i was going to fix it but didn't have time so I removed the milestone. I actually opened a larger mobile issue here: https://github.com/primefaces/primereact/issues/3949

yaiir-a commented 1 year ago

OK thanks! I'll keep my eye on that one

thejus557 commented 1 year ago

Actually, im using reordering data table in my project but drag and drop not working in mobile. Any update on this @melloware

melloware commented 1 year ago

Nope the ticket is still open and PrimeTek is going to work on all accessibility issues in 11.0.0