primefaces / primereact

The Most Complete React UI Component Library
https://primereact.org
MIT License
6.58k stars 990 forks source link

Checkboxes & toggles broken #6328

Closed DavidH541 closed 5 months ago

DavidH541 commented 5 months ago

Describe the bug

Upgrading from v10.5.1 to 10.5.2 breaks our checkboxes and toggles:

image to image and image to image and image to image

Reproducer

No response

PrimeReact version

10.5.2

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

melloware commented 5 months ago

Please upgrade to 10.6.2 and you need Theme CSS changes.

CerCap commented 5 months ago

I have this same issue. working fine on 10.5.0 but any version above that the checkboxes and radio buttons break. 10.6.2 doesn't seem to work even with a theme

edit: seems to be working fine on 10.5.1 aswell but 10.5.2 is not working

melloware commented 5 months ago

Yep its because your Theme.css is out of date. What theme are you using?

DavidH541 commented 5 months ago

"./themes/custom/theme.scss";

with theme.scss being @import './variables'; @import './_fonts'; @import '../../theme-base/_components'; @import './_extensions';

with _components.scss being @import '_mixins'; @import '_colors';

@import './components/input/_editor';

@layer primereact { @import '_common';

//Input
@import './components/input/_autocomplete';
 @import ... etc.

Did this change in newer version?

CerCap commented 5 months ago

Yep its because your Theme.css is out of date. What theme are you using?

Its a custom theme. not sure what i would need to change to fix this.

nitrogenous commented 5 months ago

You can update your custom theme components based on this PR. Warmest Regards

https://github.com/primefaces/primereact-sass-theme/commit/9cb51c75107d50d88e22f571c958d9780a6987d8

DavidH541 commented 5 months ago

Will try, thank you for the comment!