search

primefaces / primereact

The Most Complete React UI Component Library
https://primereact.org
MIT License
6.69k stars 1.01k forks source link

Dialog: Draggable dialog with position is moved on simple click #7176

Open ayonix opened 2 weeks ago

ayonix commented 2 weeks ago

Describe the bug

When a dialog is draggable and has a position, the dialog moves a bit into the given direction by a simple click on the draggable header. This also sometimes happens when you want to close the dialog. Instead of closing the dialog moves some distance, which can be frustrating.

Reproducer

https://stackblitz.com/edit/irricn?file=src%2FApp.jsx

System Information

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    primereact: latest => 10.8.2 
    react: 18.3.1 => 18.3.1

Steps to reproduce the behavior

  1. Open the dialog
  2. Click (don't drag) on the dialog header
  3. The dialog moves

Expected behavior

The dialog shouldn't move if it isn't dragged, but only clicked.

melloware commented 2 weeks ago

See this: https://github.com/primefaces/primereact/pull/3715