search

primefaces / primeui

Rich set of javascript-css only widgets
http://www.primefaces.org/primeui
278 stars 125 forks source link

Fixed compatibility issue between the stickyHeader and filter… #225

Closed StephenCWills closed 8 years ago

StephenCWills commented 8 years ago

Fixed compatibility issue between the stickyHeader and filter features of puidatatable.

When using stickyHeader and column filters together in the puidatatable, the sticky header covers up the original header including the input fields for the filters. However, the filter function still uses the text in the input fields of the original header, not the sticky header. This change modifies the filterElements array in the _initStickyHeader function so that the filter function uses the input fields in the sticky header instead.

StephenCWills commented 8 years ago

To replicate, apply "stickyHeader: true" to the data table and "filter: true" to the columns.

Here is a jsfiddle demonstrating the issue. http://jsfiddle.net/staphen/axaszzep/

StephenCWills commented 8 years ago

Fixed in https://github.com/primefaces/primeui/commit/89c452a7b1897c33990684cbf5cdde766e793f31 and confirmed in jsfiddle. http://jsfiddle.net/staphen/n10zxsfL/