search

primefaces / primevue-nuxt-module

MIT License
70 stars 11 forks source link

Features: `importPT` fields are displayed in the source code #28

Closed LemonAppleMo closed 8 months ago

LemonAppleMo commented 8 months ago

I don't think that field should be in the runtime config. 😂

https://primevue.org/nuxt/#importpt

image

LemonAppleMo commented 8 months ago

https://github.com/primefaces/primevue-nuxt-module/blob/main/src/module.ts#L42-L47

const { importPT, ...restModuleOptions } = moduleOptions;

nuxt.options.runtimeConfig.public.primevue = {
  ...restModuleOptions,
  ...registered
};

I think it's better this way.

mertsincan commented 8 months ago

Hi,

This is related to serializable definitions. Please see my comments; https://github.com/primefaces/primevue-nuxt-module/issues/6#issuecomment-1772954754

Best Regards,

LemonAppleMo commented 7 months ago

I'm so sorry. I've been so busy with the company for the last two months.

Thank you so much for answering my question. 😊😊