primefaces / primevue-sass-theme

PrimeVue Theming with SASS
https://primevue.org/theming/#customtheme
MIT License
64 stars 36 forks source link

Some classes are missing from theme-base #2

Closed dekztah closed 8 months ago

dekztah commented 1 year ago

primevue/resources/primevue.css from the the original package has some classes that are missing from this repository. for example .p-hidden-accessible or .p-overflow-hidden , so you still need to import /node_modules/primevue/resources/primevue.min.css in parallel with your theme.

I'm not sure this is intentional, but in the tutorial video (Create your own PrimeVue Themes) there is no mentioning of this.

Both versions are at 3.26 on my local.

cerinoligutom commented 1 year ago

Also encountering this issue.

r25s commented 1 year ago

I suspect this could be happening in my case also. I am using Nuxt and loading theme.scss in the nuxt configuration. So far, most things look fine. However, the floating label for the Text Input doesn't work unless I also import primevue.css.

Here is my nuxt.config.ts file:

export default defineNuxtConfig({
    css: [
        'assets/themes/material/material-dark/standard/deeppurple/theme.scss',
        'primevue/resources/primevue.css',
    ],
    build: {
        transpile: ['primevue'],
    }
})

Using version 3.26.1

cerinoligutom commented 1 year ago

It was the password component for me and it didn't look right when I tried the Basic example. The workaround that @dekztah presented works since it contains the missing classes. Particularly some classes at Common.css

Thought of making a PR but upon checking the other frameworks, the classes are missing as well so if this was intentional (I'd like to think otherwise) then maybe we're missing an instruction. Worst-case scenario, there are more missing classes that we have yet to discover.

Vue has 73 lines while React and Angular has 68 lines so they're even missing one more class .p-icon.

cagataycivici commented 8 months ago

They are added dynamically after the introduction of unstyled mode as they are still used in unstyled mode as well so they moved to core.