search

primefaces / primevue-tailwind

PrimeVue Components Styled with Tailwind CSS
https://tailwind.primevue.org
MIT License
611 stars 74 forks source link

Typescript support for presets? #66

Closed MacroMan closed 1 month ago

MacroMan commented 9 months ago

We have js disabled in our codebase so are unable to use a preset. Are there any plans to convert the presets to Typescript?

mertsincan commented 9 months ago

Thanks a lot for your report! I'll talk about it with our team and decide asap.

Best Regards,

MacroMan commented 9 months ago

We've decided to convert the Lara preset to TS ourselves as it doesn't seem like a huge effort. I'll be willing to push that back in a PR if you're interested.

MacroMan commented 9 months ago

I have converted the Lara preset to Typescript and opened a PR here: https://github.com/primefaces/primevue-tailwind/pull/74

demiro commented 9 months ago

Yeah, it's super weird you don't offer TS version of pre-sets, as most of people use vue 3 in TS mode... and linters protest in importing js files

mertsincan commented 9 months ago

TS-supported presets are already on our roadmap, but we have not started such work until all components' presets are written. 90% of the components are complete, I will talk to the team to highlight TS support in the roadmap. Please know that the PrimeVue and Tailwind+PrimeVue presets are under heavy development and as a team we want the design to be perfect. Therefore TS support may be delayed in several versions.

@MacroMan Thanks a lot for your PR! This will really help us.

FalkoJoseph commented 9 months ago

TS-supported presets are already on our roadmap, but we have not started such work until all components' presets are written. 90% of the components are complete, I will talk to the team to highlight TS support in the roadmap. Please know that the PrimeVue and Tailwind+PrimeVue presets are under heavy development and as a team we want the design to be perfect. Therefore TS support may be delayed in several versions.

@MacroMan Thanks a lot for your PR! This will really help us.

Hey just wanted to ask: if you do add TS support, will it continue to work when you're not using TS?

Ben-Avrahami commented 7 months ago

is there a way to get a typescript preset? i have a vue 3 typescript project but i only find the presets for javascript.

MacroMan commented 7 months ago

is there a way to get a typescript preset? i have a vue 3 typescript project but i only find the presets for javascript.

Yes, I converted the Lara preset to typescript here: https://github.com/primefaces/primevue-tailwind/pull/74

cagataycivici commented 6 months ago

We'll work on this after v4 as pt names are updated in v4 to align with the CSS classes and design tokens.

BryanHuntNV commented 3 months ago

Is there any update on this?

I tried hacking the Tailwind Aura presets into Typescript. It kinda is working, but some presets seem to not be applied. For example, on a tabmenu, I see the root style applied, but not the menu style. Is there something fundamental I might be missing?

Edit: I think I figured it out. The tailwind Aura presets seem to be out of date with the latest primevue components. If I hack the preset and change menu to tablist, the styles get correctly applied.

Edit2: The action preset field doesn't seem to be working.

Edit3: The action preset really needs to be itemLink so I was finally able to get presets working for TabMenu. I think I finally understand the disconnect between the current presets and PrimeVue v4.

It would be nice if there were documentation explaining the presets syntax.

goldengecko commented 1 month ago

I started some work on a typescript implementation of the Lara preset, and it was mostly working out OK, but ran into a few problems where the types were not correct/complete e.g. I remember that the menubar was missing some things from the MenubarProps.

I had other priorities so haven't pursued it at the moment, but it would really be appreciated to have a typescript version, and in the process it would help to tidy up the type definitions.

MacroMan commented 1 month ago

@goldengecko it's probably getting a bit outdated now, but take a look at my closed PR where I already converted it for fixes: https://github.com/primefaces/primevue-tailwind/pull/74

atakantepe commented 1 month ago

Update: The issue is outdated due to changes in the project structure. We plan to introduce significant updates to the presets' usage to simplify the process and eliminate confusion. Along with these updates, TypeScript support will also be added. We’ve recognized the need for clearer and easier implementation, and the new structure will address these points.

For now, I’ll be closing this issue, but rest assured, TypeScript support is in our upcoming plans. Stay tuned for further updates!

msladek commented 4 weeks ago

@atakantepe instead of just closing the issue, can you reference any of those "significant changes" and "upcoming plans"?