v3.48.0 Breaks all Styles in Ultima Theme

caputech commented 9 months ago

Describe the bug

After v3.46.0, styles in the Ultima theme are broken. v3.47.0 caused issues with Radio Buttons / Checkboxes mostly, but v3.48.0 seems to have removed or broken all styles. This can be seen easily by simply running the latest version of the Ultima theme (5.2.0)

Reproducer

https://www.primefaces.org/store/templates.xhtml

PrimeVue version

3.48.0

Vue version

3.x

Language

ES6

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

All Styles are broken in v3.48.0 using the Ultima Theme.

load latest version of Ultima theme (v5.2.0) npm install npm run dev All styles missing/broken.

Expected behavior

Styles work as expected. Ultima was purchased with lifetime support.

dahjson commented 9 months ago

Same here, I'm using the PrimeVue Sass Theme. I just spend a good bit of time updating my broken theme for version 3.47.2, and now my theme is broken again with version 3.48.0.

antham commented 9 months ago

I picked the css from https://github.com/primefaces/primevue/commit/c6151fe1ae82f8aff132a1e3d422ed4ae4dc22a0 to replace mine (lara-light-indigo), the UI was completely broken and could figure out what was happening.

mikekidder commented 9 months ago

Themes are released with a particular version, are they not?

Sakai -- release 5.9.0
package.json -> "primevue": "3.39.0",

You can probably go up to 3.45.0, but most have had issues going beyond that version as discussed in the Discord channels. PrimeTek is transitioning is transitioning away from Primceflex to TailwindCSS

dahjson commented 9 months ago

Themes are released with a particular version, are they not?

Sakai -- release 5.9.0 package.json -> "primevue": "3.39.0",

You can probably go up to 3.45.0, but most have had issues going beyond that version as discussed in the Discord channels. PrimeTek is transitioning is transitioning away from Primceflex to TailwindCSS

That's not how PrimeVue is being advertised on the homepage: https://primevue.org

"Styled or Unstyled Choose from a variety of pre-built themes or implement your design systems with the CSS library of your choice like TailwindCSS."

"Crafted on a design-agnostic infrastructure, choose from a vast amount of themes such as Material, Bootstrap, Tailwind, PrimeOne or develop your own."

All themes should be checked before updates are pushed out, and if existing themes are broken they should be fixed. As far as I understand there should be continued support for all themes especially if they are paid themes. Each update shouldn't be constantly breaking all the themes.

mikekidder commented 9 months ago

Agree, and should of been handled better. Not defending, and don't work for them. If latest PrimeVue updates were version 4.x.x, Semantic Versioning would have made it clear they were not backwards compatible.

cvalues commented 9 months ago

We have used the theme builder to change styles at a chose theme and we are working with this theme since months. Now everything is broken, is there a way to merge our generated theme fromn the primevue themebuilder with the new changes or do we have to stay on 3.46.0?

Ky6uk commented 9 months ago

Upgrading 3.46 -> 3.48 also breaks almost every custom style in my case. I am quickly discovering that many class names are gone (but still appeared in the documentation, like p-inputswitch-checked). At the moment it looks like a huge breaking change upgrade even for a minor version. Can't find a list of breaking changes and a way how to adopt the changes after the upgrade. 🤔

mertsincan commented 8 months ago

Hi all,

PrimeVue is currently undergoing intensive development, with many improvements in progress. We're planning to update and release the complete PrimeVue template by the end of February. We apologize for the delay.

Best Regards,