[bug] Editor: remove quill styles

Hulkmaster commented 2 months ago

Describe the bug

https://primevue.org/editor/ requires quill lib to be installed separately, but provides hardcoded quill-styles (hardcoded to version 1.3.3).

latest quill version is 2.0.2 and it is incompatible with 1.3.3 styles

1) either pre-install quill (via dynamic modules) 2) or remove hardcoded quill-styles and let user provide their's own

Reproducer

https://v3.primevue.org/editor/

PrimeVue version

3.52.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

any

Steps to reproduce the behavior

go https://v3.primevue.org/editor/ check quill-styles

See they are hardcoded

try fresh project, install fresh quill (2.0.2) see that styles differ (try with highlight.js)

Expected behavior

if you expect user to provide quill lib, also expect user to provide styles

reqwire commented 1 month ago

We really need Quill 2.0 support for PrimeVue 3 due to coming browser deprecations...

Tamas-hi commented 1 month ago

Mutation event support will be disabled by default starting in Chrome 127, around July 30, 2024. Code should be migrated before that date to avoid site breakage.

With Chrome 127, now this is the message we get:

@tugcekucukoglu is there a chance you can give us an update whether the team can consider this for a fix? Thank you.

primefaces / primevue