Menu componets: Design Token does not work

ShiYaoDiving commented 3 months ago

Describe the bug

Design token do not work on MENU, these is no 'PC{id}' in the

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-fhzqdg?file=src%2FApp.vue

PrimeVue version

4.0.1

Vue version

4.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Just like the case demonstrating.

does not work ### Expected behavior I think there must be some code missing....

leosin commented 3 months ago

The same situation also has: popover, menu

ShiYaoDiving commented 2 months ago

I think it is because of the of Menu.vue. If I remove the

<Portal :appendTo="appendTo" :disabled="!popup">

(line2 in Menu.vue). The Design Token will work

ShiYaoDiving commented 2 months ago

I think it because of the Portal is outside of the div.. it iwll influence all components with that: autocomplete.calendar,,cascadeselect colorpicker contextmenu dialog dropdown menu multiselect overlaypanel....

cromerc commented 2 months ago

Running into the same problem here. Something of note, the problem only occurs when using a scoped design token. I can set the style using design tokens in my global component preset theme. However that isn't what I want to do, I want to use a scoped token to only style a specific menu and not all of them.

This is only primevue 4.0.4.

ShiYaoDiving commented 2 months ago

That’s right and i think it just because of the If you remove them from Menu.vue and the dt will work