primefaces / primevue

Next Generation Vue UI Component Library
https://primevue.org
MIT License
9.83k stars 1.18k forks source link

Nuxt plugin types break if I add @primevue/nuxt-module to modules #6289

Open frasza opened 3 weeks ago

frasza commented 3 weeks ago

Describe the bug

I have axios plugin that provides its instance to the app and in case I add @primevue/nuxt-module to the nuxt config modules array, the plugin type becomes unknown.

Might be same issue as with https://github.com/nuxt/nuxt/issues/28672 -- it was fixed with module-builder hotfix in https://github.com/nuxt-modules/i18n/pull/3071

Reproducer

https://stackblitz.com/edit/github-htegss?file=nuxt.config.ts

PrimeVue version

4.0.5

Vue version

3.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

frasza commented 3 weeks ago

cc: @danielroe

Daniel, sorry for tagging you 🙏 Thought of you jumped on as it seems to be same issue as with i18n module that you PR fixed.

danielroe commented 3 weeks ago

Yes, the module builder needs to be updated here also.

c0nd3v commented 1 week ago

Also breaking my functions from ./utils

c0nd3v commented 1 week ago

This makes my functions from ./utils unable to be used in templates. But I can still use the functions from ./utils in scripts

danielroe commented 1 week ago

I've created https://github.com/primefaces/primevue/pull/6336, but note that we also need https://github.com/primefaces/primevue/pull/6207

mertsincan commented 1 week ago

Thanks a lot, @danielroe ;)

m61x commented 4 days ago

This issue can be closed as it was resolved with the release of version 4.0.6. Both #6336 and #6207 were merged into the main branch prior to the release. Therefore, @tugcekucukoglu does not need to adjust the milestones for this issue.