Open sparrow-chik-chrk opened 5 days ago
I'm manually editing the module on my project This fix the issue #6187
I'm manually editing the module on my project This fix the issue #6187
It seems to me that this PR proposes the wrong logic. The point is that when autoImport is enabled, components should not be manually registered, right? autoImport should later, through "tree shaking," add only those components that are actually used, along with styles. Please review the register.ts
file carefully.
This PR just allows for manual component registration even when autoImport is enabled...
The issue here needs to be found in generating the types after tree shaking and determining the list of components that are being used, if I understand correctly.
I'm talking about !moduleOptions.autoImport && addComponent(opt);
If you change with moduleOptions.autoImport && addComponent(opt);
the auto import seems to work good
It only auto imports the components inside include directive in nuxt.config
The add is basically done if the auto import is true and after the filter is evaluated
!moduleOptions.autoImport && addComponent(opt);
I believe this is correct. When autoImport is set to true, components are automatically loaded by the unplugin-vue-component API, so no manual component loading using addComponent
is needed in Nuxt.
Ref: https://github.com/primefaces/primevue/issues/6007#issuecomment-2393749594
You're right, sorry
EDIT: But adding dts: true does not work for me I think i'm doing something wrong
Could you please try your case after v4.1.0 is released?
sure
@mertsincan Sorry, I don’t quite understand, the latest available version on npm is 4.0.7.
How can I test 4.1.0?
Describe the bug
Problem:
When using the
@primevue/nuxt-module
with the following configuration:autoImport: true
components.prefix
set to a custom value (e.g.,"Prime"
)The components are correctly auto-imported and work fine during build and runtime. However, in the development environment, TypeScript does not recognize these components. They are marked as unknown HTML tags, and there is no autocompletion or attribute hints provided.
If I either:
components.prefix
, orautoImport
and manually import components,Then everything works correctly, and TypeScript fully recognizes the components after restarting the dev server.
Expected Behavior:
TypeScript should recognize auto-imported components with a custom prefix and provide autocompletion and hints in the development environment.
Actual Behavior:
TypeScript does not recognize auto-imported components with a custom prefix, and they are marked as unknown HTML tags during development.
Environment:
Additional Context:
The problem seems to arise only when both
autoImport: true
and a customcomponents.prefix
are used together. Manually importing components or removing the prefix resolves the issue, but it's not ideal for larger projects that rely on auto-importing.Would appreciate any insights or potential fixes for TypeScript support with this setup. Thanks!
Reproducer
https://stackblitz.com/edit/primevue-nuxt-issue-template-si9bk9
PrimeVue version
4.0.7
Vue version
3.x
Language
TypeScript
Build / Runtime
Nuxt
Browser(s)
Chrome 90
Steps to reproduce the behavior
@primevue/nuxt-module
.Observe that:
<PrimeButton>
component. It is marked as an unknown HTML tag.Remove the
prefix
or disableautoImport
and restart the dev server to see TypeScript support restored.Expected behavior
No response