primefaces / primevue

Next Generation Vue UI Component Library
https://primevue.org
MIT License
10.85k stars 1.24k forks source link

Button: Variant "link" is not assignable #6756

Closed carloeusebi closed 1 week ago

carloeusebi commented 2 weeks ago

Describe the bug

image

Component works just fine, I think the button/index.d.ts:179 file is not updated correctly:

     * Specifies the variant of the component.
     * @defaultValue undefined
     */
    variant?: 'outlined' | 'text' | undefined;

I repeat, button works as explained in documentation: link to documentation: https://primevue.org/button/#link

Reproducer

https://stackblitz.com/edit/primevue-4-ts-vite-issue-template-jyn1kh?file=src%2FApp.vue

PrimeVue version

4.2.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

25Das commented 2 weeks ago

<Button label="Button" link /> works too and don't raise any type error. I don't know which, docs or component file, are outdated, both ways work besides type error on variant property.

mitchgibson commented 2 weeks ago

Is this a bug or does the documentation need an update?

https://primevue.org/button/#link