primefaces / primevue

Next Generation Vue UI Component Library
https://primevue.org
MIT License
10.64k stars 1.24k forks source link

Use Tailwind's 'lg' 1024px width for components breakpoint prop default value #6757

Closed connorabbas closed 1 week ago

connorabbas commented 1 week ago

Feature Request

Suggesting to use Tailwind's 'lg' 1024px breakpoint width instead of 960px for components breakpoint prop default value.

Often times elements on a page will be styled to be hidden below Tailwind's 'lg' breakpoint, the minor difference in the 960-1024px range can cause confusion when certain elements get hidden, but certain components don't follow suite.

Most notably affected component is the Menubar when I have mobile styles applied using the lg: breakpoint prefix, but the Menubar component doesn't collapse into it's mobile state within the same width.

I have to remind myself to always set this prop value so I get consistent mobile styling behavior. Considering the library officially suggests to use Tailwind as the accompanying utility styling framework, this seems like an appropriate request.

Scope

This will only update the component default values within /packages/primevue, if the idea is generally accepted I would be happy to update the values within /apps/showcase/doc as well.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **primevue** | ⬜️ Ignored ([Inspect](https://vercel.com/primetek/primevue/Ct74UFrqnpXpm2ZcX2SPLfNPm51J)) | [Visit Preview](https://primevue-git-fork-connorabbas-feature-tailwind-e0afcb-primetek.vercel.app) | Nov 9, 2024 8:12pm | | **primevue-v3** | ⬜️ Ignored ([Inspect](https://vercel.com/primetek/primevue-v3/3QNRegQxzDn5WXEnCpLR7PGeuTnB)) | [Visit Preview](https://primevue-v3-git-fork-connorabbas-feature-tailwi-9db52a-primetek.vercel.app) | Nov 9, 2024 8:12pm |
tugcekucukoglu commented 1 week ago

It's a breaking change and we're not planning to implement it.