fix: change controlled condition in BaseEditableHolder - Githubissues

primefaces / primevue

Next Generation Vue UI Component Library

https://primevue.org

MIT License

10.64k stars 1.24k forks source link

fix: change controlled condition in BaseEditableHolder #6816

Open KumJungMin opened 3 days ago

KumJungMin commented 3 days ago

Defect Fixes

fix: #6739
when manual input of datePicker is not working with the keyboard.

How to Resolve...?

If the controlled condition changed, the datePicker input can be controlled via the keyboard.

https://github.com/user-attachments/assets/6b096dd2-b894-47c9-a7f1-f3eb7ba1219d

However, I don't think this is a perfect solution. Understanding the purpose of modifying controlled in this PR might help in finding a smoother fix. @mertsincan
I would appreciate any comments regarding this matter! :)

Note: In datePicker, inProps does not include modelValue.

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

| Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **primevue** | ⬜️ Ignored ([Inspect](https://vercel.com/primetek/primevue/Bt5PtqZSb5VW6Arar315K3Cu7LFw)) | [Visit Preview](https://primevue-git-fork-kumjungmin-fix-issue-6739-primetek.vercel.app) | Nov 19, 2024 3:21pm | | **primevue-v3** | ⬜️ Ignored ([Inspect](https://vercel.com/primetek/primevue-v3/6qPoq7XDZPazx1pdfYnjEJFHQFX5)) | [Visit Preview](https://primevue-v3-git-fork-kumjungmin-fix-issue-6739-primetek.vercel.app) | Nov 19, 2024 3:21pm |