primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
64 stars 30 forks source link

[Feature request] Extend the max-width of the Hero Component's H1 #618

Open simmonsjenna opened 2 months ago

simmonsjenna commented 2 months ago

This came up in a Slack thread.

Problem

The current max-width set on the Hero Component's H1 (for Large - Desktop) sometimes causes multiple line breaks and does not accommodate long titles well. Since we tend to have very long headlines with some longer words thrown in the mix, @samoshin suggested extending the max-width.

Image

Suggested solution

Extend the max-width of the F2 Hero Headline to 9 col of 12. @nsolerieu suggested this, and I also tested multiple widths and landed on the same conclusion.

Image

Urgency

Not too urgent — by mid-July or the end of July would be ideal.

/cc @nsolerieu

waynewi commented 2 months ago

Thanks @simmonsjenna

rezrah commented 1 month ago

Update: Waiting on Site Design FR (@natalie-iv) to investigate character count based sizing.

nsolerieu commented 1 month ago

@rezrah

60 characters max seems to be the most common recommendation (See here NN Group, Here Conductor )

Image

nsolerieu commented 1 month ago

@rezrah here is a consolidated suggestion

Currently this Large hero is set at 639px which is not tied to the grid and is too narrow for long titles. This new suggestion will allow most titles to fit on 2 lines and accommodate the longer technical terms found on some of our feature pages.

Image