primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
64 stars 30 forks source link

[Feature request] Specs pricing table #683

Open nsolerieu opened 1 month ago

nsolerieu commented 1 month ago

Problem

The current comparison table and PricingOption components don't work for our complex spec based feature pricing like Codespaces, Package or Actions. We tried to retrofit these into both existing component, unsatisfyingly

Image

Solution

A dedicated specsPricingTable component that allow to display tabular data.

Image

Allow Row or Column (flow prop?) based display for more flexibility.

Image

With one structure that can flex across all type of pricing with non-identical axis item and variations in disclaimer and secondary content

Image

See explorations in figma here

Urgency

No urgency, the current feature page needing update will be built statically by @simurai (see Site deign EPIC here )

nsolerieu commented 1 month ago

Due to PMM feedback and update no need to upstream this component yet until it’s been tested.- Full doc here

@simurai static build will provide the opportunity to test assumptions and circle back

Context:

TLDR: on-hold for now