primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
72 stars 32 forks source link

Adjust text 800 line height #769

Closed danielguillan closed 1 month ago

danielguillan commented 1 month ago

Summary

Adjusts the typographic token for text-800-line-height to 100% on large viewports. This aligns Heading 2 in both design and implementation.

Supporting resources (related issues, external links, etc):

Contributor checklist:

Reviewer checklist:

Screenshots:

Please try to provide before and after screenshots or videos

Before After
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 073c7101ac07aada17297c4f85f4b45f46d3f4bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ------------------------ | ----- | | @primer/brand-primitives | Patch | | @primer/react-brand | Patch | | @primer/brand-e2e | Patch | | @primer/brand-fonts | Patch | | @primer/brand-config | Patch | | @primer/brand-storybook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

🟢 No design token changes found

github-actions[bot] commented 1 month ago

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.