primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
72 stars 32 forks source link

[Modification request] All links to be blue #770

Open nsolerieu opened 1 month ago

nsolerieu commented 1 month ago

Context

During the refactoring of our feature pages we've been using lots of rivers, pillars, cards, bento with links. The inconsistent color has been noticed at many occasion by different stakeholders.

Design suggestion

Align all components that have links to default to blue links with the following exceptions:

simurai commented 1 month ago

Issue (internal link) for the feature pages.

samoshin commented 1 month ago

Thanks for kicking this off 🙏

joshfarrant commented 1 month ago

Thanks @nsolerieu — consistency makes sense to me!

I'd be keen to get @danielguillan's thoughts on this as I don't have historical context on whether the differing colours are an oversight, or an intentional choice

tallys commented 1 month ago

Yeah I'm in for consistency — @danielguillan let me know if you have more context here

danielguillan commented 3 weeks ago

The different colors were intentional but purely aesthetic choices based on the page designs these components supported when they were introduced. I also recommend updating these to use blue by default.

There is at least one additional component that doesn't use blue links, and we should consider it as well: SectionIntro.

samoshin commented 3 weeks ago

There is at least one additional component that doesn't use blue links, and we should consider it as well: SectionIntro.

I'm supportive of making links blue globally and by default.

rezrah commented 1 day ago

👋 Checking in to see how far we want to go with this change?

We have many links on the site. Presumably we are only targeting this specific compoinent and not all links?

Image

For some historical context, links in Rivers were changed to black (from blue) during Site Refactor to address hierarchical issues with adjacent CTAs. Link to Refactor design file.

I believe that's also why SubNav, Breadcrumbs and other components use black links by default over blue ones.

I think we should selectively apply this change to our most prominent high-level patterns, where link competition is less of a concern.

There's a PR open now to update River and SectionIntro to use blue links, as these fit that criteria and were called out in the discussion above 👍

Wondering if we also want to update the following, as they were intentionally designed to default to black?

rezrah commented 1 day ago

Re-opening due to: