primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
74 stars 33 forks source link

Fix Button component reflow #774

Closed joshfarrant closed 1 month ago

joshfarrant commented 1 month ago

Summary

Fix reflow of Button component with long text content. The Button's height will now increase to fix the content.

Also corrects (what I assume to be) a mistake with the class name for Buttons with size="medium".

What should reviewers focus on?

Steps to test:

Link to Storybook

Supporting resources (related issues, external links, etc):

Contributor checklist:

Reviewer checklist:

Screenshots:

Before After
![image](https://github.com/user-attachments/assets/c3673d0a-7832-4a06-91ef-75de9a89c109) ![image](https://github.com/user-attachments/assets/dff11beb-adb8-446d-9e49-48e33a943446)
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 2d79ba154139514c48ac82274478a743599d8042

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ------------------------ | ----- | | @primer/react-brand | Patch | | @primer/brand-primitives | Patch | | @primer/brand-e2e | Patch | | @primer/brand-fonts | Patch | | @primer/brand-config | Patch | | @primer/brand-storybook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

🟢 No design token changes found

github-actions[bot] commented 1 month ago

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.