Add Icon Component

[rfearing]

Summary

Part one of adding the background around the icon inside the Bento. This adds the Icon component.

List of notable changes:

• Added Icon Component to behave similar to Card.Icon component
• To come: Update Bento to accept new Icon component.

What should reviewers focus on?

• Icon should match Card.Icon visually

Steps to test:

1. View Icon component in storybook
2. Compare to Card.Icon
3. Examine API to verify it matches other components.

Supporting resources (related issues, external links, etc):

• Towards https://github.com/primer/brand/issues/773
• Related https://github.com/github/marketing-platform-services/issues/3553

Contributor checklist:

• [ ] All new and existing CI checks pass
• [ ] Tests prove that the feature works and covers both happy and unhappy paths
• [ ] Any drop in coverage, breaking changes or regressions have been documented above
• [ ] New visual snapshots have been generated / updated for any UI changes
• [ ] All developer debugging and non-functional logging has been removed
• [ ] Related issues have been referenced in the PR description

Reviewer checklist:

• [ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
• [ ] Check that tests prove the feature works and covers both happy and unhappy paths
• [ ] Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before	After

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 86ce2528ed710ab5b869b9712621d9514c732c0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

| Name | Type | | ------------------------ | ----- | | @primer/brand-primitives | Patch | | @primer/react-brand | Patch | | @primer/brand-e2e | Patch | | @primer/brand-fonts | Patch | | @primer/brand-config | Patch | | @primer/brand-storybook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

🟢 No design token changes found

[github-actions[bot]]

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional. Artifacts can be downloaded and reviewed locally. Download links are available at the bottom of the workflow summary screen. ##### Example:  If the changes are expected, please run `npm run test:visual:update-snapshots` to replace the previous fixtures.

Review visual differences

[joshfarrant]

The other thing we'll need, alongside this implementation, is documentation.

That might be dependent on us updating the Figma as we'll likely need some images from Figma to use in the documentation.

Just flagging so we don't forget @danielguillan

[rfearing]

Thank you so much @joshfarrant for the help with prettier and with checking that accessibility! 👏🏼 ♿ ! I left a response to the span comments and I think I covered the other suggestions you made.

Thanks, again!

[joshfarrant]

Awesome, thanks for addressing those comments @rfearing 🙌

Regarding the span, I had a play around myself and I'm keen to get your thoughts.

I branched off your branch and created a PR against your branch to illustrate the changes

https://github.com/primer/brand/pull/787

I think this is the same approach you mentioned (using padding to achieve the background). I can't see any issues with this approach immediately, but keen to hear what you think.

[rfearing]

@joshfarrant That looked good! Merged it into mine. 😄