Card component dark mode fixes

joshfarrant commented 1 month ago

Summary

Fixes two issues with the Card component in dark mode.

List of notable changes:

Cards no longer expand to full width when fullWidth={false}
Cards no longer render a border when hasBorder={false}

What should reviewers focus on?

Check the docs and the Storybook to make sure these changes haven't introduced any regressions

Steps to test:

Link to Docs

Supporting resources (related issues, external links, etc):

Closes https://github.com/primer/brand/issues/780

Contributor checklist:

[x] All new and existing CI checks pass
[x] Tests prove that the feature works and covers both happy and unhappy paths
[x] Any drop in coverage, breaking changes or regressions have been documented above
[x] New visual snapshots have been generated / updated for any UI changes
[x] All developer debugging and non-functional logging has been removed
[x] Related issues have been referenced in the PR description

Reviewer checklist:

[ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
[ ] Check that tests prove the feature works and covers both happy and unhappy paths
[ ] Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Before	After
![image](https://github.com/user-attachments/assets/0722233d-dbbd-40df-b848-45f57dbe8ccb)	![image](https://github.com/user-attachments/assets/fb4ee5d7-5a35-4770-91b6-32e61851cc48)

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 2d98de61c38c6908f0d894713ac8dbea28aaa747

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

| Name | Type | | ------------------------ | ----- | | @primer/react-brand | Patch | | @primer/brand-primitives | Patch | | @primer/brand-e2e | Patch | | @primer/brand-fonts | Patch | | @primer/brand-config | Patch | | @primer/brand-storybook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

🟢 No design token changes found

github-actions[bot] commented 1 month ago

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional. Artifacts can be downloaded and reviewed locally. Download links are available at the bottom of the workflow summary screen. ##### Example: ![artifacts section of workflow run](https://user-images.githubusercontent.com/13340707/181026915-2bda8a90-58e3-40ef-a2f6-c9c4af6e9c4a.png) If the changes are expected, please run `npm run test:visual:update-snapshots` to replace the previous fixtures.

Review visual differences

primer / brand