primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
74 stars 33 forks source link

Increased spacing between `River` components on mobile viewports #791

Closed joshfarrant closed 1 month ago

joshfarrant commented 1 month ago

List of notable changes:

What should reviewers focus on?

Steps to test:

Supporting resources (related issues, external links, etc):

Contributor checklist:

Reviewer checklist:

Screenshots:

Please try to provide before and after screenshots or videos

Before After
![image](https://github.com/user-attachments/assets/d5add216-ff6a-40bb-ad0e-2ec5d572afd3) ![image](https://github.com/user-attachments/assets/e151e5cf-c562-4a91-b91b-8feea7fc2bee)
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 069dfae8f9cd8600e78dc399a6b0f3adb428fece

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ------------------------ | ----- | | @primer/brand-primitives | Patch | | @primer/react-brand | Patch | | @primer/brand-e2e | Patch | | @primer/brand-fonts | Patch | | @primer/brand-config | Patch | | @primer/brand-storybook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

🔍 Design token changes found

View CSS variable changes ```diff - --brand-River-spacing-outer: var(--base-size-28); + --brand-River-spacing-outer: var(--base-size-36); ```
github-actions[bot] commented 1 month ago

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by using the test artifacts to ensure that the changes were intentional. Artifacts can be downloaded and reviewed locally. Download links are available at the bottom of the workflow summary screen. ##### Example: ![artifacts section of workflow run](https://user-images.githubusercontent.com/13340707/181026915-2bda8a90-58e3-40ef-a2f6-c9c4af6e9c4a.png) If the changes are expected, please run `npm run test:visual:update-snapshots` to replace the previous fixtures.

Review visual differences