Closed primer-css closed 2 weeks ago
Please ensure these items are checked before merging.
github/github
, as a primary consumer of Primer Brand
bin/npm install --save --save-exact @primer/react-brand@{RC_VERSION}
Important: Verify that each workspace package has been updated correctly in their respective package.json
files/features/copilot
/enterprise
/enterprise/advanced-security
/articles/security
/articles/security/what-is-security-testing
/features/preview
/features/copilot/getting-started
and /features/copilot
/solutions/devops
/education
/mobile
/contact-sales
/about/diversity
Performed successful integration test with githubuniverse.com
, as a Tier 1 consumer of Primer Brand outside of the monolith.
Performed successful integration test with https://resources.github.com/
, as a Tier 1 consumer of Primer Brand outside of the monolith.
[ ] Add report summary of your findings, including any images. Use following template as a guide:
#### Smoke test results
- Feature 1 🟢 🟡 🔴 (choose one, depending on success levels)
{insert screenshot}
Release testing status: Ready to release 🟢 | Paused 🟡 🔴 (choose one and provide reason)
primer brand
Slack channelOur visual comparison tests did not find any differences in the UI.
Breaking change: Removed all Card-icon-background/color tokens 🟢
Before | After |
---|---|
Will need Brand Eng to remediate. cc. @raytalks
Size discrepancy fixable by adding size="medium
here
Before | After |
---|---|
Will need Brand Eng to remediate. cc. @raytalks Fixable by updating this line, which is using a deprecated CSS variable.
- background-color: var(--brand-Card-icon-background-purple);
+ background-color: var(--base-color-scale-purple-8);
River and SectionIntro link colors now default to blue 🟢
Links without additional overrides now default to blue as expected. On many pages however, overrides prevent the link color from changing. This will need to be updated on case-by-case basis.
Updated Link underline to fill entire width 🟢
Updated the Card.Icon internal implementation to use the new Icon component 🟢
Disabled all transitions and auto-staggering when reduced-motion user preference is enabled 🟢
Added new background customization options to CTABanner 🔴
Blocking regression on all CTA banner instances where a default color isn't specified
Fallback value is not registering, due to malformed css in bundled output.
Will require an investigation and hotfix ⚠️
Release testing status: Not ready for release 🔴
Smoke test update:
Added new background customization options to CTABanner 🟢
Regression fixed in hotfix #814
Release testing status: Ready for release 🟢
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@primer/brand-primitives@0.42.0
Minor Changes
af335d37
Thanks @joshfarrant! - ⚠️ Breaking change: Removed all Card-icon-background/color tokens (eg--brand-Card-icon-background-blue
,--brand-Card-icon-color-orange
)@primer/react-brand@0.42.0
Minor Changes
#811
6331ae61
Thanks @rezrah! -River
andSectionIntro
link colors now default to blue (accent) for consistency withCard
,Pillar
and similar components that feature blue links.:warning: This is a visual breaking change. Please manually review all usages of
River
andSectionIntro
to ensure there is sufficient contrast with the background color.Patch Changes
#805
2928995b
Thanks @rezrah! - Disabled all transitions and auto-staggering whenreduced-motion
user preference is enabled#809
bbb14ce9
Thanks @rezrah! - UpdatedLink
underline to fill entire width#798
af335d37
Thanks @joshfarrant! - - Fixed a bug where theBento
leadingVisual
prop wouldn't honour the providedsize
.Card.Icon
internal implementation to use the newIcon
component.#810
774b91b0
Thanks @rezrah! - Added new background customization options toCTABanner
New props:
backgroundColor
backgroundImageSrc
backgroundImageSize
backgroundImagePosition
Also added
variant
prop toCTABanner.Description
, to achieve higher contrast when using background images.:link: See the documentation for more details and usage examples.
#805
2928995b
Thanks @rezrah! - Removed negative margin fromRiverStoryScroll
whenreduced-motion
user preference is enabled@primer/brand-storybook@0.42.0
@primer/brand-e2e@0.42.0
@primer/brand-fonts@0.42.0
@primer/brand-config@0.42.0