primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
74 stars 33 forks source link

Expand Link underline to full width #809

Closed rezrah closed 3 weeks ago

rezrah commented 3 weeks ago

Summary

Resolves https://github.com/primer/brand/issues/806

Increases width of underline on the Link component on hover interaction. See before and after videos below.

What should reviewers focus on?

Steps to test:

  1. Use the Storybook examples

Supporting resources (related issues, external links, etc):

-

Contributor checklist:

Reviewer checklist:

Screenshots:

Please try to provide before and after screenshots or videos

Before After
https://github.com/user-attachments/assets/a2c5b0f0-4d47-4495-9400-30abfd3928e6 https://github.com/user-attachments/assets/4e110a0c-55c9-4e5b-85d1-4b9a67c0f5d4
changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 65962a20b73662cf6cefefaa87a2c6a73aaf2571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ------------------------ | ----- | | @primer/react-brand | Patch | | @primer/brand-primitives | Patch | | @primer/brand-e2e | Patch | | @primer/brand-fonts | Patch | | @primer/brand-config | Patch | | @primer/brand-storybook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 weeks ago

🟢 No design token changes found

github-actions[bot] commented 3 weeks ago

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.