primer / brand

React components and Primitives for GitHub marketing websites
https://primer.style/brand
MIT License
74 stars 33 forks source link

Fix TextInput, TextArea, and Select width bug #828

Open joshfarrant opened 5 days ago

joshfarrant commented 5 days ago

Summary

Fixes a bug where TextInput, TextArea, and Select components expand to the width of their parent FormControl's validation message.

https://github.com/user-attachments/assets/8a7b6730-308e-4a9d-9409-93f0fbf2c7a5

List of notable changes:

What should reviewers focus on?

Steps to test:

1. 1. 1.

Supporting resources (related issues, external links, etc):

-

Contributor checklist:

Reviewer checklist:

changeset-bot[bot] commented 5 days ago

🦋 Changeset detected

Latest commit: b9384c2347f73d44e2779a53f933a38e0e5ffdc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ------------------------ | ----- | | @primer/react-brand | Patch | | @primer/brand-primitives | Patch | | @primer/brand-e2e | Patch | | @primer/brand-fonts | Patch | | @primer/brand-config | Patch | | @primer/brand-storybook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 5 days ago

🟢 No design token changes found

github-actions[bot] commented 5 days ago

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by using the test artifacts to ensure that the changes were intentional. Artifacts can be downloaded and reviewed locally. Download links are available at the bottom of the workflow summary screen. ##### Example: ![artifacts section of workflow run](https://user-images.githubusercontent.com/13340707/181026915-2bda8a90-58e3-40ef-a2f6-c9c4af6e9c4a.png) If the changes are expected, please run `npm run test:visual:update-snapshots` to replace the previous fixtures.

Review visual differences